fix LinAlgError in HSGP-Basic.ipynb, drop find_constrained_prior #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ands which raise warnings
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AlexAndorra
approved these changes
Jul 27, 2025
There was a problem hiding this comment.
Looks good; good catch @Armatron44 !
I'll give @bwengals a few hours before merging, in case he wants to add something, but the stabilization of the covariance matrix looks good to me.
|
View / edit / reply to this conversation on ReviewNB bwengals commented on 2025-08-07T06:01:30Z Line #10. cov_mat_jitted = pm.gp.util.stabilize(cov_func(x[:, None])) Small nit: jitted means something else right? Maybe call it |
|
Thanks @Armatron44! |
bwengals
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #800. In addition, I spotted that the to be depreciated
find_constrained_priorwas still being used in the linearized HSGP model example, so I switched for the prelizmax_entapproach.I've specified the number of chains to run to match old version of notebook (my old pc will only run 2 by default). I also suppressed some user warnings from matplotlib by dropping calls to
plt.tight_layoutandplt.subplots_adjust.{Insert Description}
Helpful links
📚 Documentation preview 📚: https://pymc-examples--801.org.readthedocs.build/en/801/